On Fri, 13 Feb 2026 09:21:16 GMT, Daniel Fuchs <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - split the test method arguments into individual parts
>> - no need for the duplicate null check
>> - use HttpTestEchoHandler in the new test
>
> test/jdk/java/net/httpclient/NullReturningBodyHandlerTest.java line 204:
>
>> 202: if (version == Version.HTTP_3) {
>> 203: builder.setOption(HttpOption.H3_DISCOVERY,
>> HTTP_3_URI_ONLY);
>> 204: }
>
> Should we assert that version == HTTP_2 instead? Since we only use warmup for
> HTTP/2.
That sounds reasonable to me. I've updated the PR with that change and also
merged against latest master branch.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29691#discussion_r2805273499
