On Tue, 30 Dec 2025 17:40:47 GMT, Michael McMahon <[email protected]> wrote:

>> Hi,
>> 
>> This is an update to the httpserver networking tests to change the usage of 
>> testng to junit.
>> 
>> Thanks,
>> Michael
>
> Michael McMahon has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   removed remaining PER_CLASS annotations

test/jdk/com/sun/net/httpserver/DateFormatterTest.java line 49:

> 47: import org.junit.jupiter.api.BeforeAll;
> 48: import org.junit.jupiter.api.Test;
> 49: import org.junit.jupiter.api.TestInstance;

no longer needed

test/jdk/com/sun/net/httpserver/simpleserver/CommandLinePortNotSpecifiedTest.java
 line 87:

> 85:      */
> 86:     @Test
> 87:     public static void testPortNotSpecified() throws Throwable {

Suggestion:

    public void testPortNotSpecified() throws Throwable {

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28908#discussion_r2653526111
PR Review Comment: https://git.openjdk.org/jdk/pull/28908#discussion_r2653529755

Reply via email to