On Thu, 18 Dec 2025 21:08:02 GMT, Michael McMahon <[email protected]> wrote:
> Hi,
>
> This is an update to the httpserver networking tests to change the usage of
> testng to junit.
>
> Thanks,
> Michael
LGTM.
test/jdk/com/sun/net/httpserver/BasicAuthenticatorRealm.java line 67:
> 65:
> 66: @Test
> 67: @Order(1)
does the method order matter here?
test/jdk/com/sun/net/httpserver/HeadersTest.java line 268:
> 266: @MethodSource("headerPairs")
> 267: public void testEqualsAndHashCode(Headers h1, Headers h2) {
> 268: // avoid testng's asserts(Map, Map) as they don't call
> Headers::equals
I suppose we can drop this testng comment now
test/jdk/com/sun/net/httpserver/simpleserver/CustomFileSystemTest.java line 448:
> 446: Files.createSymbolicLink(symlink, target);
> 447: } catch (UnsupportedOperationException uoe) {
> 448: Assumptions.assumeFalse(true, "sym link creation not
> supported");
Suggestion:
Assumptions.abort("sym link creation not supported");
test/jdk/com/sun/net/httpserver/simpleserver/CustomFileSystemTest.java line 450:
> 448: Assumptions.assumeFalse(true, "sym link creation not
> supported");
> 449: } catch (IOException ioe) {
> 450: Assumptions.assumeFalse(true, "probably insufficient
> privileges to create sym links (Windows)");
Suggestion:
Assumptions.abort("probably insufficient privileges to create sym
links (Windows)");
test/jdk/com/sun/net/httpserver/simpleserver/SimpleFileServerTest.java line 501:
> 499: Files.createSymbolicLink(symlink, target);
> 500: } catch (UnsupportedOperationException uoe) {
> 501: Assumptions.assumeFalse(true, "sym link creation not
> supported");
Suggestion:
Assumptions.abort("sym link creation not supported");
test/jdk/com/sun/net/httpserver/simpleserver/SimpleFileServerTest.java line 503:
> 501: Assumptions.assumeFalse(true, "sym link creation not
> supported");
> 502: } catch (IOException ioe) {
> 503: Assumptions.assumeFalse(true, "probably insufficient
> privileges to create sym links (Windows)");
Suggestion:
Assumptions.abort("probably insufficient privileges to create sym
links (Windows)");
-------------
Marked as reviewed by djelinski (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/28908#pullrequestreview-3606973045
PR Review Comment: https://git.openjdk.org/jdk/pull/28908#discussion_r2642279588
PR Review Comment: https://git.openjdk.org/jdk/pull/28908#discussion_r2642318465
PR Review Comment: https://git.openjdk.org/jdk/pull/28908#discussion_r2642368242
PR Review Comment: https://git.openjdk.org/jdk/pull/28908#discussion_r2642368920
PR Review Comment: https://git.openjdk.org/jdk/pull/28908#discussion_r2642370324
PR Review Comment: https://git.openjdk.org/jdk/pull/28908#discussion_r2642370741
