On Wed, 10 Dec 2025 13:43:18 GMT, Daniel Jeliński <[email protected]> wrote:

>> @djelinski Fixed the intermittent test failures:
>>   - Removed `close()` call after GOAWAY to avoid connection reset errors
>>   - Server now relies on Http2TestServer for connection cleanup
>>   - Tested 10 times locally, all passed
>> 
>>   Should be stable now. Please review when you get a chance
>
> @ehs208  thanks for that, the test looks stable now.
> 
> Looking at the test logs, I realized why the `goAwaySentLatch.await` was 
> where you originally had it; now that it's after all 3 requests, the requests 
> are sent on 3 distinct connections, which is not what we want. Please move it 
> back to its original position (after sending first request). Sorry for my 
> confusion.

@djelinski Oops, you're right! I moved `goAwaySentLatch.await()` back to its 
original position and now it works as expected - only 1 connection is created 
initially, and the other 2 are retries. Tested locally and all passed.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28632#issuecomment-3637345928

Reply via email to