On Tue, 9 Dec 2025 17:58:00 GMT, Daniel Fuchs <[email protected]> wrote:
> I have looked at the changes and they look good. Thanks for the cleanup! I > have sent this change to the CI for a last round of checking and tests came > back green. Thank you for reviewing! > Several of these updated files will need a copyright year update. For > example, in Authenticator.java, please update `2006, 2023,` to `2006, 2025,` > and in DefaultHttpServerProvider.java change `2005,` to `2005, 2025,`. Please > update the other updated files accordingly. Hi @jaikiran, The primary goal of this PR is to fix broken formatting and apply style cleanup only, I think. In such cases, is it expected to update the copyright year for changes that are purely mechanical, such as whitespace or formatting cleanup, with no semantic impact? My understanding was that copyright updates are typically done when there are meaningful code or semantic changes, and that updating the year for whitespace-only changes might introduce unnecessary churn. For example, Authenticator.java was last substantively updated in 2023, and in this PR it is only being touched due to whitespace. Personally, I would prefer to finish this PR as a formatting-only change and, if needed, handle copyright year updates separately in a dedicated batch ticket. That said, since I am still relatively new to OpenJDK, I would appreciate clarification on the preferred practice here so I can follow the correct convention going forward. ------------- PR Comment: https://git.openjdk.org/jdk/pull/28660#issuecomment-3635510912
