On Mon, 8 Dec 2025 21:56:57 GMT, Weijun Wang <[email protected]> wrote:
>> Daniel Jeliński has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fail test if no exception is thrown > > Any reason why `getHeaderValue` is not updated the same way? There are > several places where the return value is set into a request. I have no memory > of the details but it makes me feel uneasy. Thanks @wangweij for the review. I didn't want to modify any of the existing URLConnection behaviors, and authentication schemes that use `getHeaderValue` do not throw when the function fails. The schemes that use `setHeaders` were already throwing exceptions to user code sometimes, and I augmented these exceptions with additional information. ------------- PR Comment: https://git.openjdk.org/jdk/pull/28601#issuecomment-3630834374
