On Fri, 5 Dec 2025 10:32:14 GMT, Daisuke Yamazaki <[email protected]> wrote:
>> Hello mainteners,
>>
>> I cleaned up inconsistent spacing across the httpserver codebase.
>>
>> 1. Removed extra spaces before parentheses in function and constructor
>> declarations to make them consistent.
>> 2. Applied the same rule to function and constructor calls.
>> 3. Normalised other spacing based on the majority style already used in the
>> codebase.
>> 4. Left spots untouched where keeping the spacing improves readability.
>>
>> **This PR only adds or removes spaces. No functional changes.**
>>
>> If you think it would have been better to update only the documentation part
>> and leave the logic untouched, please let me know.
>> I split the commits, so I can easily revert the one that touches the logic.
>
> Daisuke Yamazaki has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Fix wrong indentation in package-info.java
src/jdk.httpserver/share/classes/sun/net/httpserver/ExchangeImpl.java line 344:
> 342: }
> 343:
> 344: public InetSocketAddress getRemoteAddress(){
Please add a space between `()` and `{`
src/jdk.httpserver/share/classes/sun/net/httpserver/ExchangeImpl.java line 351:
> 349: }
> 350:
> 351: public InetSocketAddress getLocalAddress(){
Here and for `getProtocol()` method too, please add a space between `()` and
`{`.
src/jdk.httpserver/share/classes/sun/net/httpserver/FixedLengthInputStream.java
line 50:
> 48: }
> 49:
> 50: protected int readImpl(byte[]b, int off, int len) throws IOException {
Please add a space between `byte[]` and `b`
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28660#discussion_r2597266083
PR Review Comment: https://git.openjdk.org/jdk/pull/28660#discussion_r2597269866
PR Review Comment: https://git.openjdk.org/jdk/pull/28660#discussion_r2597272666
