On Wed, 3 Dec 2025 12:49:31 GMT, Jaikiran Pai <[email protected]> wrote:
>> The `jdk.httpclient.quic.maxBidiStreams` is an undocumented system property >> only used in tests. This property is only useful to control the default >> HTTP/3 test server implementation. It will never be documented or exposed. >> It should be clearly labelled as internal. >> The HTTP/3 client always provide a value of 0 for the >> `initial_max_streams_bidi` transport parameter, so the default value that >> the quic stack uses internally to set the parameter if no value is provided >> is never used on the client side. >> >> The `H3StreamLimitReachedTest` can be used to verify the change - it won't >> pass if the property is not correctly configured in the test. >> >> I have also taken this opportunity to add comments to the >> `H3StreamLimitReachedTest` and the `StreamLimitTest`, to explain the logic >> of each test. >> >> With this I believe that we can also say that this change will fix >> [JDK-8365794](https://bugs.openjdk.org/browse/JDK-8365794). > > test/jdk/java/net/httpclient/http3/H3StreamLimitReachedTest.java line 43: > >> 41: * for the retry. >> 42: * @bug 8372951 >> 43: * @comment this test also tests bug 8372951 > > Nit - i think we can remove these `@comment` lines because the `@bug` already > states that this tests `8372951`. If we do retain this comment line, then it > would mean we have to keep updating it (along with `@bug` every time there a > new bug fix this test verifies). There was no `@bug` comment before, so I didn't want to give the impression that this test only tested `@bug 8372951`. This is just an indication that it can also be used to test this particular fix ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28611#discussion_r2585267179
