On Fri, 21 Nov 2025 13:01:07 GMT, Oumaiyma Intissar <[email protected]> wrote:

>> Constructing URLPermission with an empty/missing host in the authority 
>> (e.g., `"http:///path"`) could throw `StringIndexOutOfBoundsException`.
>> 
>> **Problem**
>> Empty or malformed authorities reach HostPortrange, which does `charAt(0)` 
>> without checking, causing `StringIndexOutOfBoundsException`.
>> 
>> **Fix**
>> - `URLPermission.Authority`: after stripping userinfo, fail fast if host 
>> part is empty.
>> - `HostPortrange`: add guards for null/empty input and leading ':' (port 
>> without host).
>> - No `HttpURLConnection` changes needed in JDK 26 (the `SecurityManager` 
>> permission path is gone).
>> 
>> **Compatibility**
>> Only affects malformed inputs: previously `StringIndexOutOfBoundsException`, 
>> now `IllegalArgumentException`. Valid inputs unaffected.
>> 
>> **Testing**
>> New jtreg test: `test/jdk/java/net/URLPermission/EmptyAuthorityTest.java` 
>> verifies `IllegalArgumentException` for malformed authorities and success 
>> for valid ones.
>
> Oumaiyma Intissar has updated the pull request with a new target base due to 
> a merge or a rebase. The incremental webrev excludes the unrelated changes 
> brought in by the merge/rebase. The pull request contains two additional 
> commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into 8367049
>  - 8367049: URLPermission.<init> throws StringIndexOutOfBoundsException in 
> avm mode

Marked as reviewed by dfuchs (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/27896#pullrequestreview-3492665933

Reply via email to