On Wed, 19 Nov 2025 12:58:28 GMT, Daniel Fuchs <[email protected]> wrote:

>> Jaikiran Pai has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   use Utils.toIOException()
>
> src/java.net.http/share/classes/jdk/internal/net/http/Http2Connection.java 
> line 38:
> 
>> 36: import java.net.http.HttpHeaders;
>> 37: import java.nio.ByteBuffer;
>> 38: import java.nio.channels.NetworkChannel;
> 
> Unless I'm mistaken this import is not needed?

The javadoc comment I added to `Http2Connection.isOpen()` uses `{@linkplain 
NetworkChannel#isOpen() channel is open}`. It looks like the IDE added it for 
that reason. I'm going to see if removing the import will cause any build 
failures in any places.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28233#discussion_r2542027764

Reply via email to