On Mon, 3 Nov 2025 12:18:17 GMT, Alan Bateman <[email protected]> wrote:

>> [TEST] com/sun/net/httpserver/Test9.java fails with 
>> java.nio.file.FileSystemException
>
> test/jdk/com/sun/net/httpserver/Test9.java line 126:
> 
>> 124:                 executor.shutdown ();
>> 125:             Files.delete(smallFilePath);
>> 126:             Files.delete(largeFilePath);
> 
> Wouldn't it be better to have the test wait until the HttpsServer have 
> stopped and the executor has terminated?

The test used 2 approaches here: deleteOnExit() and explicit delete, so my idea 
here to align behaviour to use single approach that will delete files, plus the 
stop method timeout was updated from 2 to 0 couple commits ago, so wasn't sure 
if it's good idea to pop it up again.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28108#discussion_r2486653511

Reply via email to