On Fri, 31 Oct 2025 11:50:28 GMT, Daniel Fuchs <[email protected]> wrote:
>> Peyang has updated the pull request incrementally with one additional commit >> since the last revision: >> >> Add documentation for HTTP range requests support in SimpleFileServer > > src/jdk.httpserver/share/classes/sun/net/httpserver/simpleserver/FileServerHandler.java > line 362: > >> 360: ranges.add(new RangeEntry(start, end)); >> 361: } >> 362: return ranges; > > I believe we should also return null if we haven't reached the end of the > string. Can that happen? Maybe not - I'd expect the unit test to verify that. Thanks, that's covbered. Any incomplete or malformed spec including trailing commas or spaces returns `null` and the new unit tests verify this behavior. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28021#discussion_r2481489277
