On Thu, 30 Oct 2025 12:39:09 GMT, Peyang <[email protected]> wrote: >> Not a reviewer, but I'd go further: this kind of method should be directly >> unit tested (not indirectly through all the http layers), and full coverage >> ensured. > > Thanks for your reviews. > Regarding adding comments to the method, I will make the corresponding > changes. > As for the unit tests, it is indeed more reasonable to test this method > directly rather than through the HTTP layer. > With that in mind, would it be okay to make this method package-private so > that it can be called from the test code and properly unit tested?
Yes that would be OK. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28021#discussion_r2478141352
