On Mon, 13 Oct 2025 11:02:51 GMT, Konrad Windszus <[email protected]> wrote:
>> Currently `HttpRequest::timeout` only applies until the response headers are >> received. Extend its scope to also cover the consumption of the response >> body. >> >> ### Review guidelines >> >> 1. Read _"the fix"_ in `MultiExchange` >> 2. Skim through the test server *handler* in `TimeoutResponseTestSupport` >> 3. Review first `TimeoutResponseHeaderTest`, and then >> `TimeoutResponseBodyTest` (Mind the multiple `@test` blocks!) > > @vy Thanks a lot for driving this. I think also the javadoc of the request > timeout should be clarified with what timeframe exactly it refers to. @kwin, thanks for your kind words. We really appreciate your feedback on `HttpClient`. I'm glad to see you even cross-linked other Issues/PRs from other projects. This really helps us with prioritizing tasks. If you have any feedback regarding `HttpClient`, you're most welcome to [the OpenJDK `net-dev` mailing list](https://mail.openjdk.org/mailman/listinfo/net-dev). > I think also the javadoc of the request timeout should be clarified with what > timeframe exactly it refers to. Thanks for pointing this out. I gave it a shot in 6615e3ab3, though this is a delicate subject, and the script will probably be amended by others' comments. And before I forget... ------------- PR Comment: https://git.openjdk.org/jdk/pull/27469#issuecomment-3406071056
