On Tue, 21 Oct 2025 15:43:24 GMT, Daniel Fuchs <[email protected]> wrote:

>> Josiah Noel has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Refactor module-info.java for imports and notes
>>   
>>   Updated import statement and modified implementation notes.
>
> test/jdk/com/sun/net/httpserver/ExchangeAttributePerExchangeTest.java line 29:
> 
>> 27:  * @summary Test HttpExchange set/getAttribute do not affect HttpContext 
>> attributes
>> 28:  * @library /test/lib
>> 29:  * @run junit/othervm ExchangeAttributePerExchangeTest
> 
> Suggestion:
> 
>  * @run junit/othervm ExchangeAttributePerExchangeTest
>  * @run junit/othervm -Djdk.httpserver.attributes=context 
> ExchangeAttributePerExchangeTest
>  * @run junit/othervm -Djdk.httpserver.attributes=random-string 
> ExchangeAttributePerExchangeTest
>  * @run junit/othervm -Djdk.httpserver.attributes 
> ExchangeAttributePerExchangeTest

Then also modify the AttribHandler::exchange to consult the property and react 
appropriately.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27652#discussion_r2448827197

Reply via email to