On Wed, 8 Oct 2025 15:07:17 GMT, Daniel Fuchs <[email protected]> wrote:
> The TimeoutBasic.java test expects that HttpTimeoutException will be either > the root cause, or the cause of the root cause of a CompletionException, > while in fact it could be further down the cause chain. The test logic should > be relaxed to allow that. > > In addition I have logged a followup RFE > ([JDK-8369315](https://bugs.openjdk.org/browse/JDK-8369315)) to possibly > revisit the wrapping of HttpTimeoutExceptions. Marked as reviewed by vyazici (Committer). test/jdk/java/net/httpclient/TimeoutBasic.java line 156: > 154: > 155: // print not matching exception stack trace > 156: e.printStackTrace(out); I don't know if this is intentional, but this will duplicate the stack trace in the JTreg output – the other one will be emitted due to `throw new AssertionError` at line 165. I'm fine with keeping it, but replacing lines 155-165 with a throw new AssertionError("could not find `HttpTimeoutException` in the causal chain", x); one-liner is good enough, IMHO. ------------- PR Review: https://git.openjdk.org/jdk/pull/27694#pullrequestreview-3315840069 PR Review Comment: https://git.openjdk.org/jdk/pull/27694#discussion_r2414556970
