On Fri, 3 Oct 2025 07:13:21 GMT, Jaikiran Pai <[email protected]> wrote:
> Can I please get a review of this test-only change which addresses > intermittent failures in `GetHTTP3Test` and `PostHTTP3Test`? > > As noted in https://bugs.openjdk.org/browse/JDK-8368821, these two tests have > been reported to fail intermittently, especially when the host on which it > runs is under heavy resource usage or when run with JVM options like `-Xcomp`. > > The commit in this PR removes the connection timeout that was enforced on the > connection attempts by the test. As far as I can see, they aren't necessary > for what this test is testing. The change also updates a few other places in > this test which had specific values for timeouts when checking if the > `HttpClient` had shutdown. These places have been updated to take into > account the timeout factor when computing the timeout. > > The changes have been verified by Matthias and SendaoYan who originally > reported these issues. I will run this change in our CI too before > integrating. The proposed changes look good to me. I agree that the connection timeout is not needed for the purpose of the test. It might have been added to fail the test earlier while working on the implementation and running the test locally, but if it causes trouble in higher tiers I believe we can remove it safely. ------------- Marked as reviewed by dfuchs (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/27619#pullrequestreview-3298382070
