On Thu, 2 Oct 2025 13:12:07 GMT, Mahendra Chhipa <[email protected]> wrote:
> Update SimpleHttpServer class to use SimpleFileServer. Hello Mahendra, it's good that we are moving to use the `com.sun.net.httpserver.SimpleFileServer` in this test library class. However, it looks like before this change, this test library class was using a `Executor` which allowed it to handle multiple requests concurrently and thus serve the files concurrently. With this change, the requests will now be handled serially because the lack of any executor being configured on the internal `HttpServer` instance backing the `SimpleFileServer` instance. Looking at the references of this `jdk.test.lib.net.SimpleHttpServer` test library class, I see only 3 tests using it. I wonder if we should just delete this class altogether and instead using the the `SimpleFileServer` at the call sites as and how necessary. ------------- PR Review: https://git.openjdk.org/jdk/pull/27608#pullrequestreview-3297482783
