On Wed, 24 Sep 2025 13:57:04 GMT, Daniel Fuchs <[email protected]> wrote:

> The java/net/httpclient/RedirectTimeoutTest.java has been observed failing 
> (once) for HTTP/3 on Windows in tier 7 (debug builds)
> 
> The log reveals that it's the HEAD request used for warmup that is failing in 
> timeout. This was surprising as this HEAD request was not supposed to be 
> configured with a timeout, and a reading of the test code revealed that a 
> non-obvious call to HttpRequest.Builder::copy was missing in the test. I 
> added that call, which should fix the issue.

This looks good to me. When reading code, reuse of builders always requires 
going back each line and seeing what its state is. So like you note, this is 
easy to overlook.

-------------

Marked as reviewed by jpai (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/27471#pullrequestreview-3263124091

Reply via email to