Can I please get a review of this test-only change which removes the use of 
`Thread.stop()` from the test? This addresses 
https://bugs.openjdk.org/browse/JDK-8360981.

The use of `Thread.stop()` `test/jdk/java/net/Socket/DeadlockTest.java` isn't 
necessary for what this test is currently testing. The commit in this PR 
removes that call and instead wait for the `Thread` to complete execution, by 
calling `Thread.join()` without any timeouts. If a genuine deadlock does 
happen, then the test will time out (on the `Thread.join()` call) and the jtreg 
infrastructure should then help get hold of the necessary thread dumps to 
identify the cause of the deadlock.

The test continues to pass with this change.

-------------

Commit messages:
 - remove Thread.stop() from test/jdk/java/net/Socket/DeadlockTest.java test

Changes: https://git.openjdk.org/jdk/pull/26490/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=26490&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8360981
  Stats: 22 lines in 1 file changed: 7 ins; 7 del; 8 mod
  Patch: https://git.openjdk.org/jdk/pull/26490.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/26490/head:pull/26490

PR: https://git.openjdk.org/jdk/pull/26490

Reply via email to