On Mon, 30 Jun 2025 15:23:22 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Can I please get a review of this change which updates the >> `jdk.internal.net.http.HttpConnection` to keep track of the origin server >> for which the `HttpConnection` was constructed? This addresses >> https://bugs.openjdk.org/browse/JDK-8361060. >> >> This is an internal implementation change which will allow other parts of >> the JDK's HttpClient implementation to use the origin server information. An >> example of such usage is the alternate services that are going to be >> supported in the JDK's HttpClient upcoming implementation for HTTP/3. >> >> No new tests have been introduced and existing tests in tier1, tier2 and >> tier3 continue to pass. > > Jaikiran Pai has updated the pull request incrementally with four additional > commits since the last revision: > > - SNI server names can now be derived from the Origin instance > - strip the square brackets from URI's host when constructing an Origin > - support only lower case http and https literals for scheme in Origin > - add new line Looks good. I wonder if we should lower case the host returned by getHost() too (when not a literal address). ------------- PR Review: https://git.openjdk.org/jdk/pull/26041#pullrequestreview-2971761888
