On Thu, 8 May 2025 16:10:18 GMT, Daniel Fuchs <[email protected]> wrote:
>> Please find her a patch that deprecate networking permission classes for
>> removal. The method `URL::getPermission` now serves little purpose and is
>> also deprecated. That method was overridden in subclasses and specified to
>> return some of the deprecated permissions.
>
> Daniel Fuchs has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The pull request contains five additional
> commits since the last revision:
>
> - Merge branch 'master' into deprecate-net-perms-8353642
> - Revert changes to SocketPermission and CodeSource
> - Review feedback. Deprecate getPermission for removal.
> - Missing white spaces
> - 8353642: Deprecate networking permission classes for removal
src/java.base/share/classes/java/net/HttpURLConnection.java line 615:
> 613: */
> 614: @Deprecated(since = "25", forRemoval = true)
> 615: @SuppressWarnings("removal")
Do you still need this annotation now that `SocketPermission` is not deprecated
for removal?
src/java.base/share/classes/sun/net/www/protocol/file/FileURLConnection.java
line 214:
> 212: */
> 213: @Override
> 214: @Deprecated(since = "25", forRemoval = true)
Is this annotation required or more as a reminder that the superclass method is
deprecated?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24592#discussion_r2082086475
PR Review Comment: https://git.openjdk.org/jdk/pull/24592#discussion_r2082050913
