On Tue, 6 May 2025 08:03:27 GMT, Alan Bateman <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Alan's review suggestion - simplify Socket constructor API documentation
>
> src/java.base/share/classes/java/net/SocketImpl.java line 86:
>
>> 84: * The {@code stream} parameter provided a way in early JDK releases
>> 85: * to create a {@link Socket} that used a datagram socket.
>> 86: * It is no longer possible to do that and therefore this method will
>
> "It is no longer possible to do that ...", can you try changing this to "The
> Socket API no longer provides a way to do this so the create method will ways
> to be called with a stream value of true". I think it might be a bit easier
> to read.
Done
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25031#discussion_r2075042155
