On Mon, 5 May 2025 12:11:16 GMT, Eirik Bjørsnøs <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> review suggestion - throw IOException
>
> src/java.base/share/classes/java/net/SocketImpl.java line 85:
>
>> 83: * @apiNote
>> 84: * The {@link Socket} constructors to create a datagram socket
>> 85: * are deprecated for removal and have been respecified to throw
>
> This seems to talk about past, current and future behavior.
>
> I thought we try to keep specifications focused on current behavior, with the
> exception of deprecation warnings.
>
> Would it be possible to reword this without mentioning the past, avoiding the
> “have been respecified” part?
>
> Interested users can always use release notes to observe history..?
Hello Eirik,
> This seems to talk about past, current and future behavior.
> ...
> Would it be possible to reword this without mentioning the past, avoiding the
> “have been respecified” part?
That's a good point. I've now updated the PR to reword this. Hopefully that's
better.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25031#discussion_r2073342198
