On Mon, 7 Apr 2025 07:43:28 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Volkan Yazici has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Use `othervm` in `@run` > > test/jdk/java/net/httpclient/HttpResponseConnectionLabelTest.java line 35: > >> 33: >> 34: // `othervm` in `@run` is intentionally introduced, don't remove it! >> 35: // It helps with, in case `ForkJoinPool.commonPool()` gets corrupt by >> the test, reusing it again. > > jtreg allows for `@comment` tag in the test definition. So you could replace > this newly added code comment with something like: > > @comment othervm usage is intentional since this test uses > ForkJoinPool.commonPool() > > > just before the `@run ....` line in the test definition Thanks, updated in 741a2dd0a67dd70e38bdbccd6598c8757aba3ab4. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24154#discussion_r2030690942
