On Wed, 26 Mar 2025 10:49:06 GMT, Volkan Yazici <vyaz...@openjdk.org> wrote:

>> Adds `HttpResponse::connectionLabel` method that provides an identifier for 
>> the connection.
>> 
>> **Implementation note:** The feature is facilitated by 
>> `HttpConnection::label`, which should not be confused with 
>> `HttpConnection::id`. This distinction is explained in the JavaDoc of both 
>> properties.
>
> Volkan Yazici has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Improve JavaDoc

src/java.net.http/share/classes/jdk/internal/net/http/HttpConnection.java line 
100:

> 98:      * {@link PlainHttpConnection} it wraps will share the same label. As 
> a
> 99:      * result, compared to {@link #id}, this label does not give a total 
> order
> 100:      * among instances.

Hello Volkan, I think we shouldn't talk about any kind of ordering here. I see 
that the `id` field has been updated with a comment stating that it provides 
ordering among instances. Even there, I don't think that comment about ordering 
is needed. So far we haven't used the `id` to mean anything other than a 
logical identifier and these values have played no role in ordering of 
connections at any place. So adding the comments about ordering, I think, makes 
it confusing.

src/java.net.http/share/classes/jdk/internal/net/http/HttpConnection.java line 
103:

> 101:      * </p>
> 102:      */
> 103:     final String label;

I think this should be `private`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24154#discussion_r2016534183
PR Review Comment: https://git.openjdk.org/jdk/pull/24154#discussion_r2016534620

Reply via email to