On Tue, 4 Mar 2025 18:37:48 GMT, Daniel Fuchs <[email protected]> wrote:
>> SendaoYan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update the comment and remove "import jtreg.SkippedException"
>
> test/jdk/java/net/InetAddress/getOriginalHostName.java line 45:
>
>> 43: InetAddress ia = null;
>> 44: ia = getInetAddress(HOST);
>> 45: if (ia != null) testInetAddress(ia, HOST);
>
> I noticed that's there is one missing test case. This should not throw
> UnknownHostException either.
>
> Suggestion:
>
> ia = getInetAddress(HOST);
> if (ia != null) testInetAddress(ia, HOST);
> ia = InetAddress.getByAddress(HOST, new byte[] { 1, 2, 3, 4});
> testInetAddress(ia, HOST);
Thanks. Test `InetAddress.getByAddress("dummyserver.java.net", new byte[] { 1,
2, 3, 4})` has been added and verified locally.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23767#discussion_r1980521449
