On Tue, 4 Mar 2025 10:52:18 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> SendaoYan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unnecessary Exeception
>
> test/jdk/java/net/InetAddress/getOriginalHostName.java line 46:
>
>> 44: ia = getInetAddress(HOST);
>> 45: if (ia != null) testInetAddress(ia, HOST);
>> 46: ia = getInetAddress("255.255.255.0");
>
> Please revert the changes on this line. UnknownHostException should not be
> thrown here.
Thanks, the change of "255.255.255.0" has been reverted.
> test/jdk/java/net/InetAddress/getOriginalHostName.java line 47:
>
>> 45: if (ia != null) testInetAddress(ia, HOST);
>> 46: ia = getInetAddress("255.255.255.0");
>> 47: if (ia != null) testInetAddress(ia, null);
>
> No need to test for `null` here (at line 47).
Thanks, the change of "255.255.255.0" has been reverted.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23767#discussion_r1979275720
PR Review Comment: https://git.openjdk.org/jdk/pull/23767#discussion_r1979276539
