On Mon, 3 Mar 2025 14:35:30 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:

>> SendaoYan has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Remove "@build jtreg.SkippedException"
>
> test/jdk/java/net/InetAddress/getOriginalHostName.java line 47:
> 
>> 45:             final String HOST = "dummyserver.java.net";
>> 46:             InetAddress ia = null;
>> 47:             ia = InetAddress.getByName(HOST);
> 
> The try-catch should be around this call only. Stg like:
> 
> 
> try {
>      ia = InetAddress.getByName(HOST);
> } catch (UnknownHostException uhe) {
>     System.out.println("Skipping " + HOST + " due to " + uhe;
> }
> if (ia != null) testInetAddress(ia, HOST);

Only catch UnknownHostException for InetAddress.getByName(String). PR has been 
updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23767#discussion_r1978525007

Reply via email to