On Fri, 21 Feb 2025 11:40:18 GMT, Volkan Yazici <vyaz...@openjdk.org> wrote:
>> Hi - Please find here a PR that improves streaming strategy in the >> HttpClient. >> >> The HttpClient currently waits until the full request body has been sent >> before starting to listen for a response. This is not optimal, in particular >> in cases where the server sends back e.g. 500 without even reading the body. >> It also prevents starting to stream the response body from the server before >> having sent the full request body, which prevents the server to stream back >> the request body to the client without reading it fully first. >> >> While writing a test to verify the fix, I also noticed a few places where >> additional tasks needed to be performed asynchronously (= delegated to the >> executor) to support this. > > test/jdk/java/net/httpclient/PostFromGetTest.java line 31: > >> 29: * @library /test/lib /test/jdk/java/net/httpclient/lib >> 30: * @build jdk.httpclient.test.lib.common.HttpServerAdapters >> jdk.test.lib.net.SimpleSSLContext >> 31: * ReferenceTracker PostFromGetTest > > Is `PostFromGetTest` needed here? It may not be - but I have taken the habit of explicitely listing the test class itself ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23716#discussion_r1971426536
