On Tue, 11 Feb 2025 10:09:35 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> test/jdk/java/net/httpclient/DigestEchoClient.java line 531:
>>
>>> 529: if (error != null) {
>>> 530: if (failed != null) error.addSuppressed(failed);
>>> 531: throw error;
>>
>> Do you think an additional `error != failed` check would be needed here,
>> before calling `addSuppressed()` or is that not a concern here?
>
> `error` is a brand new AsssertionError created by the tracker. It simply
> can't be the same exception as `failed`.
You are right - I missed that `error` is declared and assigned just one line
above this and that can only be an `AssertionError`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23515#discussion_r1950590767
