On Thu, 6 Feb 2025 19:35:22 GMT, Artur Barashev <abaras...@openjdk.org> wrote:
>> RFC 7301 says: >> >> o Identification Sequence: The precise set of octet values that >> identifies the protocol. This could be the UTF-8 encoding >> [[RFC3629](https://datatracker.ietf.org/doc/html/rfc3629)] of the >> protocol name. >> >> I'll change to `octet byte ordering`. > > I still think that `Convert to the default ALPN encoding` comment is less > confusing, we are just passing the string in the encoding that the library > expects. Basically your comment assumes reader's familiarity with the RFC. `Convert UTF-8 bytes to the string with default ALPN encoding` also sounds like an option. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23379#discussion_r1945330434
