On Mon, 20 Jan 2025 17:31:44 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
> The test/jdk/java/net/httpclient/HttpsTunnelAuthTest.java has been observed > failing at least once. The suspicion is that it may be due to the client URI > using "localhost" instead of a literal IP. > > The test has also been slightly refactored to close the created HttpClient > instances after use. The servers that are created in these tests (through the `DigestEchoServer`) go through various layers during creation but they do indeed use loopback address for binding. So this change to use loopback address for the client request URI looks fine to me. ------------- Marked as reviewed by jpai (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/23203#pullrequestreview-2564158360
