On Thu, 12 Sep 2024 15:43:32 GMT, Alan Bateman <al...@openjdk.org> wrote:
>>> Thanks for making the changes. LGTM, assuming that tests still pass. >> >> The tests passed the JDK tiers 1-3 tests on Linux, macOS, and Windows. In >> any case, I will run another round of tests before integrating. > >> The tests passed the JDK tiers 1-3 tests on Linux, macOS, and Windows. In >> any case, I will run another round of tests before integrating. > > Can you hold off integrating, I plan to go over the changes soon. > @AlanBateman I think what is holding this PR back is that you said you wanted > to review it. I asked Brian to hold off integrating this as I need time to work through several issues. Note that this is just one part of overall solution, we don't know yet if this changes in this PR will help the startup issue that motivated it (in isolation, the changes in this PR don't make sense of course). ------------- PR Comment: https://git.openjdk.org/jdk/pull/20317#issuecomment-2586989708
