On Thu, 9 Jan 2025 15:34:31 GMT, Brian Burkhalter <b...@openjdk.org> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Brian's inputs > > src/jdk.httpserver/share/classes/module-info.java line 30: > >> 28: * for running a minimal HTTP server. >> 29: * >> 30: * <p>The API, SPI and the server implementation in this module is >> intended > > 1. Add a comma after SPI. ( I had to look up that acronym). > 2. Change "is intended" to "are intended." Thank you Brian for these inputs. I have updated the PR to follow these suggestions. > Add a comma after SPI. ( I had to look up that acronym). That's a good point. The first usage of SPI was a few lines below the current proposed text. And on that first usage, it was fully spelled out as "Service Provider Interface (SPI)". I've now moved that part to this line and replaced that second usage with just SPI. > src/jdk.httpserver/share/classes/module-info.java line 32: > >> 30: * <p>The API, SPI and the server implementation in this module is >> intended >> 31: * for simple usages like local testing, development, and debugging. >> 32: * Accordingly, the design and implementation of the server is explicitly > > Change "is explicitly" to "are explicitly"? Done > src/jdk.httpserver/share/classes/module-info.java line 33: > >> 31: * for simple usages like local testing, development, and debugging. >> 32: * Accordingly, the design and implementation of the server is explicitly >> 33: * minimal so as to avoid confusion with a full-featured and high > > Replace "and" with a comma? Done. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23004#discussion_r1910452338 PR Review Comment: https://git.openjdk.org/jdk/pull/23004#discussion_r1910452514 PR Review Comment: https://git.openjdk.org/jdk/pull/23004#discussion_r1910452910
