On Tue, 3 Dec 2024 17:18:13 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Volkan Yazıcı has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Keep the overflow > > src/jdk.httpserver/share/classes/sun/net/httpserver/ServerConfig.java line 53: > >> 51: >> 52: private static long idleTimerScheduleMillis; >> 53: private static long idleIntervalMillis; > > while you're at it you could make these two fields final as well and use > temporary variables in the static block to make sure they're assigned only > once. Made 5 more variables `final` in 32fe1457e41f23d86c88590aee8173ff91e9e7af. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22510#discussion_r1868372895
