On Fri, 29 Nov 2024 13:16:51 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Can I please get a review of this doc-only change which proposes to clarify >> the behaviour of `com.sun.net.httpserver.HttpExchange.setAttribute()` and >> `com.sun.net.httpserver.HttpExchange.getAttribute()` methods? >> >> As noted in https://bugs.openjdk.org/browse/JDK-8235786, it's not clear from >> the javadoc of these methods that the attributes that are set or retrieved >> through the exchange are actually those that belong to the entire >> `com.sun.net.httpserver.HttpContext` and thus are shared by all exchanges. >> >> The commit in this PR specifies this behaviour to match the current >> implementation. I'll file a CSR once we settle on the text. > > Jaikiran Pai has updated the pull request incrementally with one additional > commit since the last revision: > > update an existing test to verify HttpExchange.getAttribute()/setAttribute() Thank you Michael and Daniel for the reviews. The CSR has been approved and tier1 and tier2 testing has passed with this change. I'll go ahead and integrate this now. ------------- PR Comment: https://git.openjdk.org/jdk/pull/22454#issuecomment-2513417209
