On Thu, 21 Nov 2024 09:44:50 GMT, Volkan Yazıcı <[email protected]> wrote:
>> Removes `SecurityManager` et al. from `SocksSocketImpl`. `tier2` and `tier3`
>> tests have passed – CI run links are available in the ticket.
>
> Volkan Yazıcı has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert to using a synchronized method to perform the connection
src/java.base/share/classes/java/net/SocksSocketImpl.java line 246:
> 244: // server is not null only when the socket was created with a
> 245: // specified proxy in which case it does bypass the
> ProxySelector
> 246: @SuppressWarnings("removal")
Suggestion:
Redundant suppression.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22271#discussion_r1852450124
