On Tue, 19 Nov 2024 11:21:38 GMT, Eirik Bjørsnøs <eir...@openjdk.org> wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains two additional >> commits since the last revision: >> >> - merge latest from master branch >> - 8344223: Remove calls to SecurityManager and doPrivileged in >> java.net.URLClassLoader after JEP 486 integration > > src/java.base/share/classes/jdk/internal/loader/BuiltinClassLoader.java line > 387: > >> 385: Enumeration<URL> e = findResourcesOnClassPath(name); >> 386: >> 387: // concat the resources from the modules and the class path > > Observation: This is now essentially `ClassLoader.CompoundEnumeration`, which > could be reused if moved to `jdk.internal.loader`. Probably not for this PR > though. The new comment isn't quite right, it should say "concat the URLs to the resource in the modules and the class path". ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22233#discussion_r1848178162
