On Sat, 16 Nov 2024 12:19:33 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Calls to getSecurityManager, checkPermission, and doPrivileged are removed. >> >> - URLUtils.getConnectPermission is still used in the client area and >> couldn't be removed right away. >> [JDK-8344303](https://bugs.openjdk.org/browse/JDK-8344303) has been logged. >> >> - Similarly, URLConnection.getPermission is a public API. >> [JDK-8344308](https://bugs.openjdk.org/browse/JDK-8344308) has been logged >> to deprecate it for removal. > > Daniel Fuchs has updated the pull request incrementally with one additional > commit since the last revision: > > Review feedback: no longer unwrap ServiceConfigurationError Thanks for the update, looks okay to me. src/java.base/share/classes/java/net/URL.java line 930: > 928: * Returns the address of the host represented by this URL. > 929: * An {@link UnknownHostException} > 930: * while getting the host address will result in this method > returning If you are doing any further edits then maybe re-flow this paragraph. ------------- PR Review: https://git.openjdk.org/jdk/pull/22153#pullrequestreview-2440773270 PR Review Comment: https://git.openjdk.org/jdk/pull/22153#discussion_r1845094884