On Tue, 8 Oct 2024 13:08:26 GMT, Michael McMahon <micha...@openjdk.org> wrote:

>> This fix relaxes the constraints on user set authentication headers. 
>> Currently, any user set authentication headers are filtered out, if the 
>> HttpClient has an Authenticator set. The reason being that the authenticator 
>> is expected to manage authentication.  With this fix, it will be possible to 
>> use pre-emptive authentication through user set headers, even if an 
>> authenticator is set. The expected use case is where the authenticator would 
>> manage either proxy or server authentication and the user set headers would 
>> manage server authentication if the authenticator is managing proxy (or vice 
>> versa).
>> If the pre-emptive authentication fails, then this behavior is disabled on 
>> further retries and it would be up to the authenticator to provide the right 
>> credentials then.
>> 
>> Thanks,
>> Michael
>
> Michael McMahon has updated the pull request with a new target base due to a 
> merge or a rebase. The incremental webrev excludes the unrelated changes 
> brought in by the merge/rebase. The pull request contains 102 additional 
> commits since the last revision:
> 
>  - Merge branch 'master' into 8326949-authorize
>  - 8336843: Deprecate java.util.zip.ZipError for removal
>    
>    Reviewed-by: liach, lancea
>  - 8341597: ZipFileInflaterInputStream input buffer size uses uncompressed 
> size
>    
>    Reviewed-by: lancea
>  - 8339220: [s390x] TestIfMinMax.java failure
>    
>    Reviewed-by: lucy, aph
>  - 8341594: Use Unsafe to coalesce reads in java.util.zip.ZipUtils
>    
>    Reviewed-by: lancea
>  - 8339836: Open source several AWT Mouse tests - Batch 1
>    
>    Reviewed-by: honkar, prr
>  - 8339982: Open source several AWT Mouse tests - Batch 2
>    
>    Reviewed-by: psadhukhan
>  - 8341668: Shenandoah: assert(tail_bits < (idx_t)BitsPerWord) failed: 
> precondition
>    
>    Reviewed-by: ysr
>  - 8341581: Optimize BytecodeHelpers validate slot
>    
>    Reviewed-by: liach
>  - 8341278: Open source few TrayIcon tests - Set7
>    
>    Reviewed-by: azvegint
>  - ... and 92 more: https://git.openjdk.org/jdk/compare/9376c222...99553407

It looks like I made a mess of the last resync and rebased the latest changes 
from master onto my own branch. I will have to close this PR and create a new 
one with the current patch.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21249#issuecomment-2399836132

Reply via email to