On Thu, 8 Aug 2024 09:11:31 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Brian Burkhalter has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> commits since the last revision:
>>
>> - Merge
>> - 8337143: Removed dependency of libjava on headers in libnio/ch
>> - 8337143: Move natives to <platform>/native/libjava/nio/{ch,fs} as a
>> function of their original location in libnio
>> - 8337143: (fc, fs) Move filesystem-related native objects from libnio to
>> libjava
>
> src/java.base/share/classes/java/net/Inet6AddressImpl.java line 154:
>
>> 152: static {
>> 153: jdk.internal.loader.BootLoader.loadLibrary("net");
>> 154: }
>
> I am curious about this change - wouldn't it be needed in Inet4AddressImpl as
> well?
I have not seen any failures in CI testing. Is there a specific test that would
reveal whether this is a problem?
> src/java.base/windows/native/libjava/IOUtil.c line 37:
>
>> 35: #include "nio.h"
>> 36: #include "nio_util.h"
>> 37: /* #include "net_util.h" */
>
> Is this change intended or is this a left over from some experimentation?
It could be leftover. There was a lot of wrangling in this. Probably line 37
could just be deleted.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20317#discussion_r1709645656
PR Review Comment: https://git.openjdk.org/jdk/pull/20317#discussion_r1709647530
