On Mon, 5 Aug 2024 15:19:33 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
> This will introduce a source code dependency from libjava to libnio. It might > be the correct thing to do, but I just want to highlight this. I'll look into improving it. > make/modules/java.base/lib/CoreLibraries.gmk line 71: > >> 69: -framework Foundation \ >> 70: -framework SystemConfiguration, \ >> 71: LIBS_windows := advapi32.lib ole32.lib shell32.lib version.lib >> mswsock.lib ws2_32.lib, \ > > Please keep libraries alphabetically sorted. Thanks for pointing this out; I will fix it. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20317#discussion_r1704310018 PR Review Comment: https://git.openjdk.org/jdk/pull/20317#discussion_r1704310460
