On Fri, 26 Apr 2024 15:37:13 GMT, robert engels <d...@openjdk.org> wrote:
>> improve the HttpExchange api with documented constants and convenience >> methods to avoid common bugs > > robert engels has updated the pull request incrementally with one additional > commit since the last revision: > > Update > src/jdk.httpserver/share/classes/com/sun/net/httpserver/HttpExchange.java > > Co-authored-by: Michael McMahon > <70538289+michael-mc-ma...@users.noreply.github.com> src/jdk.httpserver/share/classes/com/sun/net/httpserver/HttpExchange.java line 227: > 225: sendResponseHeaders(code, NO_CONTENT); > 226: close(); > 227: } I wonder if this method should better be called `sendResponseNoContent(int code)`; Maybe wait to see if you get further suggestions. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18955#discussion_r1585019573
