On Thu, 25 Apr 2024 12:50:23 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Isn’t consistency in the code base more important. I like the change but it >> seems there should be a single PR that changes all of the test cases to this >> format. > > We have been using these newer constructs whenever a new test gets added, but > we don't update all tests in one go for such changes. If/when old tests are > updated for some bug fix relevant to that test, depending on the complexity > we either decide to let them stay as-is or update them to use these newer > constructs. Personally, I think that is not the correct choice. I think consistency is more important - especially in a code base this large. But I’ll do whatever you want. This is getting a bit frustrating. The PR review is 1% content and 99% personal nits. This is certainly a different approach than Google uses. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18667#discussion_r1579429149
