> Can I please get a review of this doc-only change which proposes to clean up > the documentation of `java.net.SocketOptions` interface? > > As noted in https://bugs.openjdk.org/browse/JDK-8329733, the existing > documentation in this legacy interface isn't accurate. The commit in this PR, > updates the documentation on several of the fields to point to the newer > java.net.StandardSocketOptions class. While at it, I also did a general > update of this documentation to use snippets and also reword some of it to be > a bit more clear. > > I have run `make docs-image` on this change and the updated doc looks fine to > me.
Jaikiran Pai has updated the pull request incrementally with three additional commits since the last revision: - "timeout value" instead of "timeout" - missed SO_TIMEOUT review suggestion in previous commit - Alan's review suggestions ------------- Changes: - all: https://git.openjdk.org/jdk/pull/18645/files - new: https://git.openjdk.org/jdk/pull/18645/files/2280b10f..0e6772ec Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=18645&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18645&range=00-01 Stats: 7 lines in 1 file changed: 2 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk/pull/18645.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18645/head:pull/18645 PR: https://git.openjdk.org/jdk/pull/18645
