On Wed, 21 Feb 2024 06:56:01 GMT, Jaikiran Pai <[email protected]> wrote:
> Can I please get a review of this change which proposes to fix > https://bugs.openjdk.org/browse/JDK-8326381? > > As noted in the JBS issue, the implementation in `setNeedClientAuth()` and > `setWantClientAuth()` of `com.sun.net.httpserver.HttpsParameters` wasn't > matching the API specification. The commit in this PR fixes that issue and it > now matches the API specification as well as what is done in > `javax.net.ssl.SSLParameters` class. > > Additionally, as noted in the JBS issue, the (internal class) > `sun.net.httpserver.SSLStreams` had a bug where it could end up resetting the > `needClientAuth` flag on the `SSLEngine` because of the way the > `setNeedClientAuth()` and `setWantClientAuth()` methods were being called on > the `SSLEngine`. This too has been fixed in this PR. > > A new jtreg test has been introduced to reproduce the issue in the > `HttpsParameters` class and verify this fix. This pull request has now been integrated. Changeset: d451f818 Author: Jaikiran Pai <[email protected]> URL: https://git.openjdk.org/jdk/commit/d451f818cf8e7cf2f619a5832c7fe5e5ed968c6a Stats: 446 lines in 3 files changed: 442 ins; 0 del; 4 mod 8326381: com.sun.net.httpserver.HttpsParameters and SSLStreams incorrectly handle needClientAuth and wantClientAuth Reviewed-by: djelinski ------------- PR: https://git.openjdk.org/jdk/pull/17940
