On Wed, 21 Feb 2024 08:44:50 GMT, John Jiang <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - introduce a test to verify the server honours needClientAuth and >> wantClientAuth when set through HttpsParameters >> - deprecate the SSL parameters related methods on HttpsParameter > > test/jdk/com/sun/net/httpserver/HttpsParametersClientAuthTest.java line 72: > >> 70: assertFalse(wantClientAuthParams.getNeedClientAuth(), >> 71: "needClientAuth was expected to be false but wasn't"); >> 72: } > > Is it necessary to check the states on the following cases? > > > HttpsParameters params = new Params(); > params.setNeedClientAuth(true); > params.setWantClientAuth(false); > > > > HttpsParameters params = new Params(); > params.setWantClientAuth(true); > params.setNeedClientAuth(false); I don't have preference, especially since we now decided to deprecate these methods. But if you prefer we add those, then let me know and I can update the test tomorrow. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17940#discussion_r1499436527
