On Thu, 16 Nov 2023 09:04:48 GMT, Alan Bateman <[email protected]> wrote:
>> Matthias Baesken has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> adjust comment in Net.c
>
> src/java.base/windows/native/libnio/ch/Net.c line 160:
>
>> 158:
>> 159: /* IPV6_V6ONLY is true by default */
>> 160: /* attempt to disable IPV6_V6ONLY to ensure dual-socket
>> support; ignore errors */
>
> You can remove the previous comment at L159.
I adjusted the comment.
> src/java.base/windows/native/libnio/ch/WindowsAsynchronousServerSocketChannelImpl.c
> line 134:
>
>> 132: SOCKET s2 = (SOCKET)jlong_to_ptr(acceptSocket);
>> 133:
>> 134: if (setsockopt(s2, SOL_SOCKET, SO_UPDATE_ACCEPT_CONTEXT, (char
>> *)&s1, sizeof(s1)) < 0) {
>
> I think this goes back to when the JDK targeted Windows releases where this
> wasn't supported or there were non-MS LSPs installed. It should be okay to
> change now.
Hi Alan, in the MS resources
https://learn.microsoft.com/en-us/windows/win32/api/mswsock/nf-mswsock-acceptex
I find some info about 'Windows XP or later' regarding the
SO_UPDATE_ACCEPT_CONTEXT option. So maybe this was the Windows release you are
referring to.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16684#discussion_r1395687380
PR Review Comment: https://git.openjdk.org/jdk/pull/16684#discussion_r1395683693
