On Tue, 24 Oct 2023 09:46:40 GMT, Conor Cleary <[email protected]> wrote:
> If Http2ClientImpl::stop() is called, it will loop through the connections > map and call the close() method on each connection. The changes in this PR > make sure that the connection thread (where close is called from) removes the > `Http2Connection` from the connection pool to prevent inactive connections > from remaining in there rather than just closing it. > > Even though the connection can be and usually is removed from the pool in > other places (reader or writer thread), this change ensures removal from the > pool in cases where the connection is shutdown by an exception, reset, etc. > The issue was first spotted when a RST_STREAM triggered repeated attempts to > remove idle connections from the pool before a regular shutdown could occur. This pull request has now been integrated. Changeset: 576c9bcc Author: Conor Cleary <[email protected]> URL: https://git.openjdk.org/jdk/commit/576c9bccfbe6718fe8fe409bc165000bd1554589 Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod 8318492: Http2ClientImpl should attempt to close and remove connection in stop() Reviewed-by: dfuchs, jpai ------------- PR: https://git.openjdk.org/jdk/pull/16340
